Skip to content
This repository

from_python was also removed from pyelasticsearch #762

Closed
robertour opened this Issue · 4 comments

2 participants

Roberto Michael Petychakis
Roberto

The method from_python was removed from ElasticSearch in pyelasticsearch, in this commit. But it is still being called at least in elasticsearch_backend.py line 758. The function is called 9 times in this file but I am not sure if all of them are related to pyelasticsearch.

This is related to this issue:
to_python is not defined in the new pyelasticsearch #758

And this pull request:
Pyelasticsearch 0.4 compatibility (fairly urgent) #759

Michael Petychakis

what is the status of this?
currently i cannot make pyelasticsearch work on my server and it is getting pretty inconvenient.
please any help would be more than welcome.
thank you!

Michael Petychakis

actually, to fix it on my platform i created a small fix
https://github.com/mpetyx/pyelasticsearch/commit/fc9e71d2f0b8fa4f7ad2af781b8f7d240fc598dd#pyelasticsearch/client.py
reverting the old "from_python", for anyone who might need it.
cheers

Jannis Leidel jezdez closed this issue from a commit
Jannis Leidel jezdez Port the `from_python` method from pyelasticsearch to the Elasticsear…
…ch backend, similar to `to_python` in 181bbc2.

Fixes #762. Refs #759.
5409197
Jannis Leidel jezdez closed this in 5409197
Michael Petychakis

nice fix. thank you!

Roberto

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.