Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapted gsoc code to current master #73

Closed
wants to merge 8 commits into from
Closed

Adapted gsoc code to current master #73

wants to merge 8 commits into from

Conversation

daniloaf
Copy link

Applying error bars feature to Codespeed 0.9 on my gsoc branch.

daniloaf and others added 6 commits June 17, 2011 12:55
@daniloaf
Updating jQuery to 1.6.1 and jqPlot to 1.0b1
3feacbc
- BUGFIX: Changing jquery version on base.html
db98c50 
- Working with error bars on Timeline view
- Using error bars on Timeline view (now fully usable)
3998742 
- Updating jqPlot to 1.0.0b2
- Adding new js file (jqplot.ohlcRendererWithErrorBars.min.js), which is a modified OHLCRenderer to allow rendering error bars
- Adding new option to settings.py (use_error_bars) to choose to use error bars or not
Changing error bar colors to a light grey
d2ec131
- Removing labels for error bars
0d1de0e 
- Adding a checkbox to toggle error bars on or off
Applying changes from tobami master branch to gsoc branch
79f09b8
@tobami
Copy link
Owner

tobami commented Jul 24, 2011

Hi Danilo.

I checked out the code, and it is looking good.

Btw., with what data set have you been developing? with pypy's? While it is useful to test how things scale to more data, I think the testdata fixtures should be the canonical way to develop, because it ensures that we all have useful data that showcases all features. I ask because codespeed/fixtures/testdata.json has so low std values (as compared to the absolute result value), that the error bars are not visible. I have modified the fixtures in master so that they would be visible.

A couple of points:

  • When error bars are not displayed, the markers should be shown as before
  • settings.USE_ERROR_BARS is upper case in example/settings, but lower case in codespeed/settings. It should also be commented out in example/settings, as all other parameters
  • Your last commit is very noisy because of the big merge, and it still conflicts. I would insist on it being better to rebase. Frank's refactoring was really big, I don't think there will be as big a refactoring again. Can you try to start a new, clean branch, up-to-date with my master, and then apply the changes one by one? It really is not something that should take you very long, and the history will be much cleaner for it

@daniloaf
Copy link
Author

Hi, Miquel.

I'm trying to rebase master and delete my gsoc branch, but it's not being an easy task.

I want to rebase master and apply my changes on it. Can you help me on this? I'm not a "pro" on github.

Thanks.

daniloaf and others added 2 commits August 6, 2011 11:47
- Multi-project support on Timeline view
e373a78 
- Changing use_error_bars on codespeed/settings.py to upper case and commented USE_ERROR_BARS on example/settings.py
- BUGFIX: Adding missing import on codespeed/__init__.py
- Showing series markers when checkbox "Show error bars" is unmarker
3839a94 
- Removing multi-project code from gsoc branch
@tobami
Copy link
Owner

tobami commented May 17, 2012

@daniloaf should I close this pull request?

@tobami tobami closed this Apr 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daniloaf @tobami @smarr