list and deploy nodes with a certain tag #121

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
2 participants
Collaborator

thekorn commented Nov 6, 2012

With this branch two new commands are added:

LittleChef: Configuration Management using Chef Solo

Available commands:

[...]
    list_nodes_with_tag     Show all nodes which have assigned a given tag
    nodes_with_tag          Sets a list of nodes that have the given tag assigned and calls node()
[...]

The idea is to be able list and deploy nodes with a certain tag, similar to how the nodes_with_role selector is working.

Sample calls would be like

% fix list_nodes_with_tag:boo
[...]
% fix nodes_with_tag:baz
[...]

Also an additional commandline switch called --include-guests is introduced. This switch is useful if you have the convention that all tags for the host are virtually also tags for the host's guests. In this case fix is not only applied on the host with a tag, but also on all of the host's guests.

I don't consider this branch done yet, but would like to get some input on the general concept first (esp. from @tobami). Missing bits are:

  • documentation in README
  • missing tests for the new functionallity (blocked by already failing tests in master #120)

Any initial comments?

Owner

tobami commented Nov 6, 2012

Looks awesome. The "include-guests" bit is kind of a new concept in LittleChef, but because it is opt-in it is alright.

Only the fix for the command tests don't look right. They fail depending on your DNS. What is needed is mocking or localhost DNS settings for tests

Owner

tobami commented Jan 15, 2013

Only the README docu entry is missing

Owner

tobami commented Mar 3, 2014

cherry-picking commits and creating new pr

@tobami tobami closed this Mar 3, 2014

@tobami tobami deleted the nodes_with_tags branch Mar 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment