Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix ssh config by letting fabric do it #148

Merged
merged 2 commits into from Jan 30, 2013

Conversation

Projects
None yet
2 participants
Contributor

michaelballantyne commented Jan 29, 2013

Fix for issue #146.

Remove littlechef's credentials function, as fabric natively handles these functions with recent releases. Littlechef's attempts were conflicting with fabric's native functionality.

Tested with Fabric 1.4.2 (minimum version supported by littlechef) and 1.5.3 (most recent version).

Tested authentication scenarios include username, password and keypair provided in config.cfg, and Host, HostName, User, and IdentityFile provided in an ssh configuration specified by ssh-config.

michaelballantyne added some commits Jan 29, 2013

Remove use of credentials(). Fabric handles all those tasks
itself, and modifications made by credentials function interacted
negatively with fabric's functionality.
Contributor

michaelballantyne commented Jan 29, 2013

Second commit should probably be a second pull request but not sure how to make that happen. Previously either a password or ssh config was required. However, a username and keypair should be sufficient (assuming user can sudo without a password).

Owner

tobami commented Jan 30, 2013

This is actually awesome. There may be some regressions, but probably nothing that cannot be easily fixed.

In any case I can confirm that using user/password/ssh-config does work

tobami added a commit that referenced this pull request Jan 30, 2013

Merge pull request #148 from michaelballantyne/master
Fix ssh config by letting fabric do it
Fixes #146

@tobami tobami merged commit 67bb45e into tobami:master Jan 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment