Many ips #14
Merged
Many ips #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As you say, the templates would be broken after merging this changesets. |
|
I just updated overview template to not more use public_ip node attribute. |
|
Very nice. I still have to test a bit more, but I will merge nonetheless! |
tobami
added a commit
that referenced
this pull request
Feb 19, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here a new pull request for management of multiples IPs per node as liblcoud >= 0.7 expose.
I rewrite NodeIP sync strategy to be consistent across multiples node updates and keep things sync correctly.
I kept public_ips and private_ips "helpers" in node. I think we should update templates to no more use public_ip
node attribute.