From a38756bd940a8b08de48c115eba466fa4405f3ae Mon Sep 17 00:00:00 2001 From: Chas Emerick Date: Thu, 9 Feb 2012 07:21:27 -0500 Subject: [PATCH] fix minor 1.3 issues, add integration poms for 1.3 + 1.4-SNAPSHOT --- src/integration/clojure-1.3.0/pom.xml | 4 +- src/integration/clojure-1.4.0/pom.xml | 44 +++++++++++++++++++ .../clojure/tools/nrepl/sanity_test.clj | 15 ++++--- src/test/clojure/clojure/tools/nrepl_test.clj | 4 +- 4 files changed, 57 insertions(+), 10 deletions(-) create mode 100644 src/integration/clojure-1.4.0/pom.xml diff --git a/src/integration/clojure-1.3.0/pom.xml b/src/integration/clojure-1.3.0/pom.xml index 3d76365..c4c2551 100644 --- a/src/integration/clojure-1.3.0/pom.xml +++ b/src/integration/clojure-1.3.0/pom.xml @@ -10,7 +10,7 @@ org.clojure clojure - 1.3.0-master-SNAPSHOT + 1.3.0 @project.groupId@ @@ -24,7 +24,7 @@ com.theoryinpractise clojure-maven-plugin - 1.3.7 + 1.3.8 @basedir@/src/test/clojure -Dnrepl.basedir=@basedir@ diff --git a/src/integration/clojure-1.4.0/pom.xml b/src/integration/clojure-1.4.0/pom.xml new file mode 100644 index 0000000..9425813 --- /dev/null +++ b/src/integration/clojure-1.4.0/pom.xml @@ -0,0 +1,44 @@ + + 4.0.0 + clojure.tools + 0.0.2-SNAPSHOT + nrepl-test-clojure-1.4.0 + nREPL (Clojure 1.4.0 tests) + + + + org.clojure + clojure + 1.4.0-master-SNAPSHOT + + + @project.groupId@ + @project.artifactId@ + @project.version@ + + + + + + + com.theoryinpractise + clojure-maven-plugin + 1.3.8 + + @basedir@/src/test/clojure + -Dnrepl.basedir=@basedir@ + + + + test-clojure + test + + test + + + + + + + \ No newline at end of file diff --git a/src/test/clojure/clojure/tools/nrepl/sanity_test.clj b/src/test/clojure/clojure/tools/nrepl/sanity_test.clj index 21e66d9..477bf34 100644 --- a/src/test/clojure/clojure/tools/nrepl/sanity_test.clj +++ b/src/test/clojure/clojure/tools/nrepl/sanity_test.clj @@ -22,15 +22,18 @@ (let [[local remote] (piped-transports) out (java.io.StringWriter.) err (java.io.StringWriter.) - expr (if (string? expr) expr (pr-str expr)) + expr (if (string? expr) + expr + (binding [*print-meta* true] + (pr-str expr))) msg (merge {:code expr :transport remote} (when ns {:ns ns})) resp-fn (if ns (juxt :ns :value) :value)] (handlers/evaluate {#'*out* (java.io.PrintWriter. out) - #'*err* (java.io.PrintWriter. err)} - msg) + #'*err* (java.io.PrintWriter. err)} + msg) (->> (repl/response-seq local 0) (map resp-fn) (cons (str out)) @@ -78,9 +81,9 @@ ["5 6 7 \n 8 9 10\n" nil] '(println 5 6 7 \newline 8 9 10) ["user/foo\n" "" nil] '(binding [*out* *err*] (prn 'user/foo))) - (is (re-seq #"java.lang.Exception: No such var: user/foo \(.*\)\n" (-> '(prn user/foo) - internal-eval - first)))) + (is (re-seq #"Exception: No such var: user/foo" (-> '(prn user/foo) + internal-eval + first)))) (deftest repl-out-writer (let [[local remote] (piped-transports) diff --git a/src/test/clojure/clojure/tools/nrepl_test.clj b/src/test/clojure/clojure/tools/nrepl_test.clj index d4e2c3c..32938a2 100644 --- a/src/test/clojure/clojure/tools/nrepl_test.clj +++ b/src/test/clojure/clojure/tools/nrepl_test.clj @@ -112,7 +112,7 @@ (def-repl-test exceptions (let [{:keys [status err value]} (combine-responses (repl-eval session "(throw (Exception. \"bad, bad code\"))"))] - (is (= #{"error" "done"} status)) + (is (= #{"eval-error" "done"} status)) (is (nil? value)) (is (.contains err "bad, bad code")) (is (= [true] (repl-values session "(.contains (str *e) \"bad, bad code\")"))))) @@ -123,7 +123,7 @@ (def-repl-test return-on-incomplete-expr (let [{:keys [out status value]} (combine-responses (repl-eval session "(missing paren"))] (is (nil? value)) - (is (= #{"done" "error"} status)) + (is (= #{"done" "eval-error"} status)) (is (re-seq #"EOF while reading" (first (repl-values session "(.getMessage *e)")))))) (def-repl-test switch-ns