CSS polish #85
Merged
CSS polish #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * <div class="sk-double-bounce1"></div> | ||
| * <div class="sk-double-bounce2"></div> | ||
| * <div class="sk-child sk-double-bounce1"></div> | ||
| * <div class="sk-child sk-double-bounce2"></div> |
There was a problem hiding this comment.
@jmagnusson Adding specific classes for shared styles here, instead of relying on for example div, 馃憤 / 馃憥 ?
|
I think your CSS/HTML skills severly out-whey mine. So do it 馃槈 |
| @@ -13,12 +13,11 @@ | |||
| &.sk-spinner { | |||
There was a problem hiding this comment.
@jmagnusson We use this pattern throughout SpinKit, but I'm considering if we should just kill this selector and make these styles part of the parent selector. E.g. making this:
.sk-spinner-double-bounce {
[styles]
}鈥ather than:
.sk-spinner-double-bounce {
&.sk-spinner {
[styles]
}
}Thoughts? 鉂わ笍
|
@jmagnusson Feeling done, mind trying this out before I merge? 馃憖 鉂わ笍 |
Lodash `template` function had a change in syntax so modified gulpfile.js to reflect this.
|
Had to update the dev dependencies to be able to run gulp. But everything seems just fine 馃憤 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing should really change because of this, purely implementation details.
cc @jmagnusson 馃憖