Skip to content
This repository has been archived by the owner on Jul 19, 2018. It is now read-only.

Handling Chrome Frame #14

Closed
tobie opened this issue Apr 9, 2012 · 7 comments
Closed

Handling Chrome Frame #14

tobie opened this issue Apr 9, 2012 · 7 comments
Assignees

Comments

@tobie
Copy link
Owner

tobie commented Apr 9, 2012

In the python implementation Chrome Frame is handled through parsing the user agent string accessible by JavaScript. This seems contrary to how Chrome Frame user agent strings are describe to work. It's also not very practical. How do you determine the UA of a CSS request, for example?

@ghost ghost assigned elsigh Apr 9, 2012
@elsigh
Copy link
Contributor

elsigh commented Apr 11, 2012

Yeah, this looks like it can now be done from the UA string. That was not always true. Will fix.

@tobie
Copy link
Owner Author

tobie commented Apr 11, 2012

OK, didn't know the history behind that. Is this something you want to do in the YAML regexes or in the Python code directly?

@elsigh
Copy link
Contributor

elsigh commented Apr 11, 2012

It should be in the YAML regexes so all parsers benefit.
I'm planning to take the @dmolsen's regexes file from https://raw.github.com/dmolsen/ua-parser-php/master/resources/user_agents_regex.yaml and replace the one in this project sometime today or tomorrow.
Once it's in, I'll add a chromeframe regex and test for python.

@tobie
Copy link
Owner Author

tobie commented Apr 11, 2012

Awesome. You do the work. I benefit. I like that. :)

@toolmantim
Copy link
Contributor

And I'll swing that into here too: https://github.com/toolmantim/user_agent_parser

@elsigh
Copy link
Contributor

elsigh commented May 4, 2012

Fixed in 191a6d8

@elsigh elsigh closed this as completed May 4, 2012
@toolmantim
Copy link
Contributor

Awesome, thanks Lindsey! I've released v0.1.2 of the user_agent_parser Ruby gem with this Chrome Frame support.

skliffmueller pushed a commit to skliffmueller/ua-parser that referenced this issue Oct 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants