Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAR1,...,VAR5 channel on every thing #95

Closed
andreacioni opened this issue Sep 19, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@andreacioni
Copy link

commented Sep 19, 2017

Issue opened due to a lot of people asking for this feature on:

@fab33

This comment has been minimized.

Copy link

commented Sep 21, 2017

I don't think it's a good idea. You can add childId with variables you need.

@andreacioni

This comment has been minimized.

Copy link
Author

commented Sep 22, 2017

Yes you could. But not I'm not sure it is the best approach. If we use your suggested solution we must consider, in order to avoid confusion, to remove channels var1,...,var5 from all things that already define them (i.e. humidity, temperature, waterMeter, etc...). Clearly we must keep 'customSensor' because it will be the one that holds var1,...,var5 channels.
By now I've not idea what is the best way, but I believe that we have only 2 possibilities:

  • Add var1,...,var5 to all things
  • Remove var1,...,var5 from all things (except 'customSensor')
@micktech

This comment has been minimized.

Copy link

commented Sep 27, 2017

It would be great to have this option available. The irrigation sketch I am using has 8 binary outputs, all with variable1-3 in use for times/naming. Creating a childid for each zone variable would mean 24+ new child IDs, It would be much neater having var1-5 available as things.

@tobof tobof added the enhancement label Sep 28, 2017

tobof added a commit that referenced this issue Oct 19, 2017

Added var1 to var5 to every sensor
* bug fixing
* addition of some sensors (gps, sceneController, moisture, sprinkler,
vibration)

Fixed #65
Fixed #95

Signed-off-by: Tim Oberföll <oberfoell@web.de>

@tobof tobof closed this in 8d587c7 Oct 19, 2017

tobof added a commit that referenced this issue Dec 6, 2018

Redesign of the ESH-INF Folder & Added var1 to var5; bugfixes (#101)
* redesign of the ESH-INF Folder
* separate file (channel-types.xml) for all channels
* separate file (gateway-types.xml) for the gateways
* separate file for every child (example: SBinary.xml, STemp.xml ..)
* added var1 to var5 to every sensor
* addition of some sensors (gps, sceneController, moisture, sprinkler,
vibration)
* bug fixing (Fixed #65 & Fixed #95)
* Adds support for MySensors MQTT gateway (Fixes #98)
* Serial refactoring (#105) (Fixes #103 & Fixes #86)
* Bugs in Expert Mode (MySensorsMessage) removed
* Added V_PERCENTAGE (Dimmer) to S_RGB & S_RGBW (#106) (Fixes #87)
* Fixed reverse (wrong) description for option networkSanCheckEnabled (Fixes #90)
* Bug: (RGB/W) ON / OFF sent instead of 0 & 1 (Fixes #108)
* Remove warning: "Overwrite variable: V_VAR1"

Signed-off-by: Tim Oberföll <oberfoell@web.de>

tobof added a commit that referenced this issue Dec 13, 2018

Redesign of the ESH-INF Folder & Added var1 to var5; bugfixes (#101)
* redesign of the ESH-INF Folder
* separate file (channel-types.xml) for all channels
* separate file (gateway-types.xml) for the gateways
* separate file for every child (example: SBinary.xml, STemp.xml ..)
* added var1 to var5 to every sensor
* addition of some sensors (gps, sceneController, moisture, sprinkler,
vibration)
* bug fixing (Fixed #65 & Fixed #95)
* Adds support for MySensors MQTT gateway (Fixes #98)
* Serial refactoring (#105) (Fixes #103 & Fixes #86)
* Bugs in Expert Mode (MySensorsMessage) removed
* Added V_PERCENTAGE (Dimmer) to S_RGB & S_RGBW (#106) (Fixes #87)
* Fixed reverse (wrong) description for option networkSanCheckEnabled (Fixes #90)
* Bug: (RGB/W) ON / OFF sent instead of 0 & 1 (Fixes #108)
* Remove warning: "Overwrite variable: V_VAR1"

Signed-off-by: Tim Oberföll <oberfoell@web.de>

tobof added a commit that referenced this issue Dec 13, 2018

Redesign of the ESH-INF Folder & Added var1 to var5; bugfixes (#101)
* redesign of the ESH-INF Folder
* separate file (channel-types.xml) for all channels
* separate file (gateway-types.xml) for the gateways
* separate file for every child (example: SBinary.xml, STemp.xml ..)
* added var1 to var5 to every sensor
* addition of some sensors (gps, sceneController, moisture, sprinkler,
vibration)
* bug fixing (Fixed #65 & Fixed #95)
* Adds support for MySensors MQTT gateway (Fixes #98)
* Serial refactoring (#105) (Fixes #103 & Fixes #86)
* Bugs in Expert Mode (MySensorsMessage) removed
* Added V_PERCENTAGE (Dimmer) to S_RGB & S_RGBW (#106) (Fixes #87)
* Fixed reverse (wrong) description for option networkSanCheckEnabled (Fixes #90)
* Bug: (RGB/W) ON / OFF sent instead of 0 & 1 (Fixes #108)
* Remove warning: "Overwrite variable: V_VAR1"

Signed-off-by: Tim Oberföll <oberfoell@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.