Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mysensors] Get MQTT working with OH2.5 #139

Merged
merged 2 commits into from Feb 7, 2020

Conversation

@ftitius
Copy link

ftitius commented Jan 26, 2020

Reenable MQTT gateway in MySensorsBridgeHandler.
Add workaround for get MQTTSession in MySensorsMqttConnection.
Combine two similiar variables 'mqttBrokerConn' and 'connection' to 'connection' in MySensorsMqttConnection.

Fixes #138
Signed-off-by: Frank Titius frank.titius@hamburg.de

Reenable MQTT gateway in MySensorsBridgeHandler.
Add workaround for get MQTTSession in MySensorsMqttConnection.
Combine two similiar variables 'mqttBrokerConn' and 'connection' to
'connection' in MySensorsMqttConnection.

Fixes #138
Signed-off-by: Frank Titius <frank.titius@hamburg.de>
@ftitius ftitius requested a review from tobof as a code owner Jan 26, 2020
Remove the static attribute from PipedOutputStream and
PipedInputStream in MySensorsMqttConnection.
Change name of cache filename to include the gateway thing uid
in  MySensorsBridgeHandler and use the filename parameter in
MySensorsCacheFactory.

Fixes #140
Signed-off-by: Frank Titius <frank.titius@hamburg.de>
@tobof tobof merged commit a5666f0 into tobof:MySensors_Binding_bnd Feb 7, 2020
@tobof

This comment has been minimized.

Copy link
Owner

tobof commented Feb 7, 2020

Thank you very much!!

@ploeffler

This comment has been minimized.

Copy link

ploeffler commented Feb 27, 2020

please excuse that I use this thread, but:
does that mean that the MQTT problems are gone now? (and is discovery workig?)

@tobof

This comment has been minimized.

Copy link
Owner

tobof commented Feb 27, 2020

Yes! If that's not the case, please report back. 😄

@ploeffler

This comment has been minimized.

Copy link

ploeffler commented Feb 27, 2020

Hooray!!!!
Where could I find the jar file? ... Will test immediately!

@guillebot

This comment has been minimized.

Copy link

guillebot commented Feb 27, 2020

@tobof

This comment has been minimized.

Copy link
Owner

tobof commented Feb 27, 2020

Hooray!!!!
Where could I find the jar file? ... Will test immediately!

LINK and via Eclipse Marketplace.

@ploeffler

This comment has been minimized.

Copy link

ploeffler commented Feb 27, 2020

Hooray!!!!
Where could I find the jar file? ... Will test immediately!

LINK and via Eclipse Marketplace.

the pain has gone
THANK YOU EVER SO MUCH!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.