New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for iOS #5

Merged
merged 2 commits into from Aug 24, 2018

Conversation

Projects
None yet
2 participants
@einaregilsson
Contributor

einaregilsson commented Aug 21, 2018

This pull request adds 2 things:

  1. iOS support. Written in Swift, tried to mimic the Android version as closely as possible.
  2. Change how the "notInEea" property of the result object is populated. Previously it was only done in the Ionic typescript wrapper. However, I'm not using Ionic, only Cordova, so I populate it in the Java code, using the consentInformation.isRequestLocationInEeaOrUnknown() method. I didn't remove the typescript handling though, since I don't know it well enough, don't know Ionic at all and am not comfortable messing with it.

Anyway, thanks for the plugin, it has been very useful for us, and I hope our iOS version can be useful to others as well :)

@tobyherrmann

This comment has been minimized.

Owner

tobyherrmann commented Aug 22, 2018

Thanks a lot for your work, that is pretty cool.
I will have a look a this (and integrate) next week, this week I am away.

@tobyherrmann tobyherrmann merged commit 7c8fa8b into tobyherrmann:master Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment