Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

18Chesapeake: Last market share can be purchased by non-president in 2p #3276

Closed
orome opened this issue Jan 13, 2021 · 0 comments · Fixed by #3399
Closed

18Chesapeake: Last market share can be purchased by non-president in 2p #3276

orome opened this issue Jan 13, 2021 · 0 comments · Fixed by #3399
Labels
18Chesapeake bug Prevents game from being played correctly

Comments

@orome
Copy link

orome commented Jan 13, 2021 •
edited

It is possible to buy a “market” share as non-president when only 1 is left in the bank pool in a 2p game of 18Chesapeake even though the rules for 2p clearly state:

If the player that is not the current president buys a company’s shares from the bank pool, immediately before buying the share, one share is removed from the game. … If there is only one share, the action still takes place, but the single share is removed from the game before the player has the opportunity to buy it.

For example, Aldaron is able to buy the single “market” share of the Lehigh Valley Railroad at this point in the game.
@yzemaze yzemaze added 18Chesapeake bug Prevents game from being played correctly labels Jan 13, 2021
@orome orome changed the title Last market share can be purchased by non-president in 2p 18Chesapeake 18Chesapeake: Last market share can be purchased by non-president in 2p Jan 13, 2021
michaeljb added a commit to michaeljb/18xx.games that referenced this issue Jan 19, 2021
@michaeljb
bug fix, 18Chesapeake 2p: unfloated corporation market share removal
66fc3a6 
if I had more time, I would move the buy_shares logic from the base SharePool
into Game and then 18Chesapeake wouldn't need to subclass the core SharePool
class

[Fixes tobymao#3276]
@michaeljb michaeljb mentioned this issue Jan 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
18Chesapeake bug Prevents game from being played correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug fix, 18Chesapeake 2p: unfloated corporation market share removal michaeljb/18xx.games
2 participants
@orome @yzemaze