Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks: Tempo, Attributions, Add settings, ABC #90

Merged
merged 21 commits into from Jul 18, 2018

Conversation

@tobyspark
Copy link
Owner

commented Jul 14, 2018

Features

  • Archiver 'add setting' has title, tempo fields to lead into changing ABC
  • Archiver 'add setting' has full abcjs editor
  • Composer has playback tempo control for each tune
  • ABC S, N, F fields are extracted from a tune's ABC to create Tune Attributions
  • Tune Attributions are exported as N fields in ABC

Fixes

  • M, K tokens generated in the ABC body are wrapped as per spec (abc2abc conform was mangling these)
  • playback of ABC with compound time
  • setting header fields conforms to X, T... K order
  • better setting novelty validation
@tobyspark

This comment has been minimized.

Copy link
Owner Author

commented Jul 14, 2018

To investigate –
TuneAttribution with URL "|"

@tobyspark tobyspark merged commit 5c67814 into master Jul 18, 2018
@tobyspark tobyspark deleted the tweaks-and-more-abc branch Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.