New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a crate for kernel/common/*Cell? #986

Closed
dancrossnyc opened this Issue Jun 12, 2018 · 7 comments

Comments

Projects
None yet
4 participants
@dancrossnyc
Copy link

dancrossnyc commented Jun 12, 2018

It would be really neat if the *Cell modules (TakeCell, MapCell, VolatileCell, etc) were available as a crate!

@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Jun 12, 2018

If this is useful it seems like a good idea to me.

I would like to see a new folder for these crates (including tock_regs) because I don't think that tools is great fit if there are going to be multiple of these split off.

@alevy

This comment has been minimized.

Copy link
Member

alevy commented Jun 13, 2018

How about extern? utils?

@dancrossnyc

This comment has been minimized.

Copy link
Author

dancrossnyc commented Jun 13, 2018

utils would be good. I could definitely find a use for it!

@brghena

This comment has been minimized.

Copy link
Contributor

brghena commented Jun 15, 2018

I'm worried that utils is too vague, especially in the root next to a directory called tools. What about libraries? Or crates?

@brghena brghena referenced this issue Jun 19, 2018

Merged

A directory for crates #1006

2 of 2 tasks complete
@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Jun 26, 2018

PR: #1014

@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Jun 26, 2018

Ok done!

@bradjc bradjc closed this Jun 26, 2018

@dancrossnyc

This comment has been minimized.

Copy link
Author

dancrossnyc commented Jun 27, 2018

This is wonderful! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment