New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcp230xx: support more versions of the chip #1004

Merged
merged 1 commit into from Jul 14, 2018

Conversation

Projects
None yet
2 participants
@bradjc
Copy link
Contributor

bradjc commented Jun 19, 2018

Pull Request Overview

The ACD52832 uses the MCP23017 i2c GPIO extender, which is very similar to the MCP23008 which we already had a capsule for, except that it has two banks of eight pins instead of one. This makes the capsule more generic so it can support one or two banks of pins.

The only thing that should change for existing users is a slight change to the new() function. Basically it accepts another option interrupt pin and it needs to know the number of pins and banks.

Testing Strategy

This pull request was tested by using it on the acd52832.

TODO or Help Wanted

Ideally this would be tested on signpost, but I'm not sure if that is realistic.

Documentation Updated

  • Kernel: Updated the relevant files in /docs, or no updates are required.
  • Userland: Added/updated the application README, if needed.

Formatting

  • Ran make formatall.
@ppannuto

This comment has been minimized.

Copy link
Member

ppannuto commented Jun 19, 2018

@ppannuto

This comment has been minimized.

Copy link
Member

ppannuto commented Jun 27, 2018

mcp230xx: support more versions of the chip
In particular, multiple banks.

@bradjc bradjc force-pushed the mcp230xx branch from 8905a47 to 6f5e1c9 Jul 9, 2018

@ppannuto
Copy link
Member

ppannuto left a comment

Reading over the code, this looks correct. I don't think either of Josh or I will realistically get to testing this on Signpost in a reasonable timeframe at this point, so we'll stop standing in the way.

@ppannuto ppannuto removed the blocked label Jul 14, 2018

@ppannuto ppannuto merged commit bedc120 into master Jul 14, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ppannuto ppannuto deleted the mcp230xx branch Jul 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment