New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adc: remove `initialize()` from HIL #1025

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
6 participants
@bradjc
Copy link
Contributor

bradjc commented Jun 25, 2018

See #1008 for more information.

Pull Request Overview

This pull request removes the initialize() function from the ADC HIL. This seems to be a consensus in #1008.

Testing Strategy

This pull request was tested by running hail on hail.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.
adc: remove `initialize()` from HIL
See #1008 for more information.
@ppannuto
Copy link
Member

ppannuto left a comment

I suppose HIL changes are probably always Significant?

@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Jun 27, 2018

@alevy ?

@dverhaert dverhaert referenced this pull request Jun 28, 2018

Merged

SAM4L analog comparator driver #837

3 of 4 tasks complete
@alevy

alevy approved these changes Jun 28, 2018

@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Jun 28, 2018

6/7 I'm calling close enough.

@bradjc bradjc merged commit c879d5f into master Jun 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@bradjc bradjc deleted the adc-no-initialize branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment