New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused feature declarations #1027

Merged
merged 1 commit into from Jun 26, 2018

Conversation

Projects
None yet
4 participants
@bradjc
Copy link
Contributor

bradjc commented Jun 25, 2018

Pull Request Overview

This pull request cleans up some #![feature()] declarations that are not needed.

Testing Strategy

This pull request was tested by compiling, but travis will be a good check.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.
#![feature(
asm, concat_idents, const_fn, const_cell_new, try_from, core_intrinsics, iterator_step_by
)]
#![feature(asm, const_fn, core_intrinsics, iterator_step_by)]

This comment has been minimized.

@niklasad1

niklasad1 Jun 25, 2018

Member

Is not step_by is stabilized now?

This comment has been minimized.

@bradjc

bradjc Jun 25, 2018

Contributor

Not with this nightly, but I can try on a new nightly.

This comment has been minimized.

@niklasad1

niklasad1 Jun 25, 2018

Member

Sorry, looked at the wrong release will definitely be in 1.28.0 but it was merged 23 days ago and should be available soon I guess!

@bradjc bradjc dismissed stale reviews from alevy and niklasad1 via 7055b69 Jun 26, 2018

@bradjc bradjc force-pushed the remove-unneeded-features branch from a543b3f to 7055b69 Jun 26, 2018

@bradjc bradjc removed the needs-rebase label Jun 26, 2018

@ppannuto ppannuto merged commit f9d097d into master Jun 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ppannuto ppannuto deleted the remove-unneeded-features branch Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment