New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix build-all-docs script #1030

Merged
merged 2 commits into from Jun 26, 2018

Conversation

Projects
None yet
2 participants
@bradjc
Copy link
Contributor

bradjc commented Jun 25, 2018

The old method was making a call to awk that was too long on linux. This method avoids that. No functionality changed.

Tested that search-index.js looks correct on mac and linux.

This should allow #1019 to pass travis.

Testing Strategy

This pull request was tested by running the script on both mac and linux.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.
tools: fix build-all-docs script
The old method was making a call to `awk` that was too long on linux.
This method avoids that. No functionality changed.

Tested that search-index.js looks correct on mac and linux.
@ppannuto
Copy link
Member

ppannuto left a comment

I can try to puzzle out a different solution, but this was probably using awk to begin with because sed -i doesn't work out-of-box on Mac :(

(I've certainly set up my system via brew to replace BSD sed with GNU sed, so it works on my machine, but will not work for people who haven't done that step)

@bradjc bradjc merged commit 5a8aa30 into master Jun 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@bradjc bradjc deleted the fix-docs-build branch Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment