New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: allow multiple LEDs for panic blinks #1036

Merged
merged 2 commits into from Jun 27, 2018

Conversation

Projects
None yet
2 participants
@ppannuto
Copy link
Member

ppannuto commented Jun 27, 2018

Pull Request Overview

This is motivated by Signpost, where some boards would like to blink
both the panic LED on the board and another one on the backplane.
Generally, it's probably better to be flexible and let board authors
blink as many LEDs as they'd like.

Testing Strategy

crash_dummy on hail

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.
@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Jun 27, 2018

Generally, it's probably better to be flexible and let board authors blink as many LEDs as they'd like.

Maybe not. Having a standard panic blink format (the red led if one exists, or the first led if not) makes it easier to ask "Is the red led blinking in a two pulse pattern?" (or something like that) when helping someone to debug, without having to look up for each board what the panic led configuration is on that particular board.

For the signpost case I think this PR clearly makes sense.

ppannuto added some commits Jun 27, 2018

kernel: allow multiple LEDs for panic blinks
This is motivated by Signpost, where some boards would like to blink
both the panic LED on the board and another one on the backplane.
Generally, it's probably better to be flexible and let board authors
blink as many LEDs as they'd like.

@ppannuto ppannuto force-pushed the panic-at-the-disco branch from 6fcca9a to 5d6be29 Jun 27, 2018

@bradjc

bradjc approved these changes Jun 27, 2018

@ppannuto ppannuto merged commit ea2a2ce into master Jun 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ppannuto ppannuto deleted the panic-at-the-disco branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment