New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove all uses of `sed` #1038

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
2 participants
@ppannuto
Copy link
Member

ppannuto commented Jun 27, 2018

Pull Request Overview

We only had one place we were still using sed, and it's pretty
easily replaced by grep. This lets us drop another one of the listed
required tools (though who doesn't have sed?).

I'm more enthused to do this because sed tends to have more cross
platform issues than other tools, so adopting the habit of not using
it will likely minimize future issues.

Testing Strategy

make alldoc

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.
tools: remove all uses of `sed`
We only had one place we were still using sed, and it's pretty
easily replaced by grep. This lets us drop another one of the listed
required tools (though who doesn't have sed?).

I'm more enthused to do this because sed tends to have more cross
platform issues than other tools, so adopting the habit of not using
it will likely minimize future issues.

@ppannuto ppannuto added the P-Upkeep label Jun 27, 2018

@ppannuto ppannuto merged commit feba7c1 into master Jun 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ppannuto ppannuto deleted the s-sed-grep branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment