New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf51: Update uart to new regs interface #1053

Merged
merged 1 commit into from Jul 8, 2018

Conversation

Projects
None yet
4 participants
@ppannuto
Copy link
Member

ppannuto commented Jul 1, 2018

Pull Request Overview

nrf51: Update uart to new regs interface

Testing Strategy

Compile-tested only.

TODO or Help Wanted

Someone with nrf51 HW make sure this doesn't break anything.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran Battled make formatall.

@bradjc bradjc referenced this pull request Jul 1, 2018

Closed

Tracking: nRF5x to new register interface #809

17 of 17 tasks complete
@niklasad1
Copy link
Member

niklasad1 left a comment

Looks good Pat, but we need to test it on hardware!

@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Jul 6, 2018

Anyone have an nrf51dk board to test this on?

@niklasad1

This comment has been minimized.

Copy link
Member

niklasad1 commented Jul 7, 2018

@ppannuto @bradjc I have but nRF51-DK doesn't work on master so I assume this doesn't work either!

@alevy

This comment has been minimized.

Copy link
Member

alevy commented Jul 7, 2018

I'll be able to test Monday...

@niklasad1

This comment has been minimized.

Copy link
Member

niklasad1 commented Jul 8, 2018

@niklasad1 niklasad1 merged commit b086f9c into master Jul 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@niklasad1 niklasad1 deleted the nrf51-regs-uart branch Jul 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment