New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Include one debug build #1055

Merged
merged 2 commits into from Jul 3, 2018

Conversation

Projects
None yet
2 participants
@ppannuto
Copy link
Member

ppannuto commented Jul 1, 2018

Pull Request Overview

This updates travis to build one board in the debug configuration. There's a tradeoff to building all of them (time) and at least one to catch errors like #1054.

Just building one is further motivated by the fact that hail and imix don't fit in ROM anymore (they're somewhere between 1-2k over) without LTO enabled.

This PR depends on #1054.
@brghena Your comment there was just a little too fast for me, I was working on it! :)

Testing Strategy

Compiling.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

@ppannuto ppannuto added the P-Upkeep label Jul 1, 2018

ppannuto added some commits Jul 1, 2018

kernel: must export symbols used by other crates
These are global symbols referenced by the arch and chip crates, so they
must be exported. Building with LTO hid this error, but if you disable
LTO then the linker will (correctly) complain about missing symbols as
these symbols aren't visible to the other crates.

@ppannuto ppannuto force-pushed the travis-debug-builds branch from 43f527a to a49b49d Jul 1, 2018

@alevy

alevy approved these changes Jul 3, 2018

@alevy alevy merged commit bd032e7 into master Jul 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@alevy alevy deleted the travis-debug-builds branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment