Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Optional cell enhancements #1056
left a comment
Are these all of the methods that are needed? Or are there more? It might be good to just fill in all of the methods that exist in normal Cell types.
Should all of the Cell types have a relatively uniform (and complete) API?
There are probably more. It wouldn't be bad to have more functionality implemented, except of course that in the case of safety-sensitive code, it's never great to have functionality that's not really used (cause bad bugs are less likely to be caught).
I don't think adding functions has the same kind of affect on backwards stability as changing existing functions, and so don't think we should block on finishing the API.
No. Different "cell" types are pretty semantically different, so I don't think it makes a ton of sense to combine their APIs
I think I'm in agreement with @phil-levis on this one. The
I went through and added the remaining methods from