New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional cell capsules #1057

Merged
merged 4 commits into from Jul 8, 2018

Conversation

Projects
None yet
5 participants
@ppannuto
Copy link
Member

ppannuto commented Jul 1, 2018

Pull Request Overview

This pull request updates capsules to use OptionalCells where appropriate.

Depends on #1056.

Testing Strategy

Compiling.

TODO or Help Wanted

Needs testing on HW:

  • sam4l platform
  • nrf5x platform
  • cc26xx platform

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

ppannuto added some commits Jul 1, 2018

tock-cells: Add `replace` method to `OptionalCell`
Sometimes you have an `Option` that you'd like to put in an `OptionalCell`,
which means you need to either `set` or `clear` to `OptionalCell` depending
on the `Option` you're putting in. This implements that logic in `OptionalCell`.

@bradjc bradjc added the blocked label Jul 5, 2018

@ppannuto ppannuto removed the blocked label Jul 7, 2018

@niklasad1
Copy link
Member

niklasad1 left a comment

Looks good to me but I would like us to begin to add more unit test in the tock libraries/crates!

@alevy alevy merged commit 2d4350e into master Jul 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@alevy alevy deleted the optional-cell-capsules branch Jul 8, 2018

alevy added a commit to alevy/tock that referenced this pull request Jul 8, 2018

Fix bad use of optioncell introduced by tock#1057
I merged tock#1057 when master had changed underneath it, so travis didn't
catch a misuse of the OptionCell type. Simple fix.

@alevy alevy referenced this pull request Jul 8, 2018

Merged

Fix bad use of optioncell introduced by #1057 #1100

2 of 2 tasks complete

bradjc added a commit that referenced this pull request Jul 9, 2018

Merge pull request #1100 from alevy/bug/fix1057
Fix bad use of optioncell introduced by #1057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment