New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional cell nrf52 #1062

Merged
merged 1 commit into from Jul 9, 2018

Conversation

Projects
None yet
4 participants
@ppannuto
Copy link
Member

ppannuto commented Jul 1, 2018

Pull Request Overview

This pull request updates nrf52 to use OptionalCells where appropriate.

Depends on #1056.

Testing Strategy

Compiling.

TODO or Help Wanted

  • Testing on nrf52 HW

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

@niklasad1 niklasad1 self-assigned this Jul 3, 2018

@bradjc bradjc added the blocked label Jul 5, 2018

@niklasad1 niklasad1 force-pushed the optional-cell-nrf52 branch from a74eafd to 6c0cebd Jul 6, 2018

@niklasad1

This comment has been minimized.

Copy link
Member

niklasad1 commented Jul 6, 2018

Doesn't work on my nRF52-DK but master doesn't work either!

EDIT: Both ble_advertising and printf_long works except #1079

@ppannuto ppannuto removed the blocked label Jul 7, 2018

@bradjc bradjc force-pushed the optional-cell-nrf52 branch from 6c0cebd to 18d9622 Jul 9, 2018

@bradjc

bradjc approved these changes Jul 9, 2018

Copy link
Contributor

bradjc left a comment

Tried on the nrf52840dk and the ble_passive_scanning app works.

@ppannuto ppannuto merged commit 9f76bf6 into master Jul 9, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ppannuto ppannuto deleted the optional-cell-nrf52 branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment