New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional cell nrf5x #1063

merged 4 commits into from Jul 8, 2018


None yet
4 participants
Copy link

ppannuto commented Jul 1, 2018

Pull Request Overview

This pull request updates nrf5x to use OptionalCells where appropriate.

Depends on #1056.

Testing Strategy


TODO or Help Wanted

  • Testing on nrf51
  • Testing on nrf52

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.


  • Ran make formatall.

ppannuto added some commits Jul 1, 2018

tock-cells: Add `replace` method to `OptionalCell`
Sometimes you have an `Option` that you'd like to put in an `OptionalCell`,
which means you need to either `set` or `clear` to `OptionalCell` depending
on the `Option` you're putting in. This implements that logic in `OptionalCell`.

@niklasad1 niklasad1 self-assigned this Jul 3, 2018

@bradjc bradjc added the blocked label Jul 5, 2018

@ppannuto ppannuto removed the blocked label Jul 7, 2018


This comment has been minimized.

Copy link

niklasad1 commented Jul 8, 2018

Tested successfully on nrf51 and nrf52 with

@niklasad1 niklasad1 removed the help wanted label Jul 8, 2018

@niklasad1 niklasad1 merged commit 100723a into master Jul 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
deploy/netlify Deploy preview ready!

@niklasad1 niklasad1 deleted the optional-cell-nrf5x branch Jul 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment