Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove wildcard imports #1077
Pull Request Overview
We've talked about this before in person, and most of Tock adheres to it, but a few wildcard imports have made their way into the tree. I've been doing a whole bunch of refactoring lately, and it's been a potent reminder of why wildcard imports are troublesome (hard to find where variables / objects come from).
As added benefit, there were a few instances (especially in the networking stack) where we were using wildcards to export interfaces that were exporting all public elements when in practice only one or two were actually used. Echoing the sentiment of #955, explicit exports help ensure that only the intended interface is available.
This removes all of the wildcard imports in the Tock tree and adds a formatting rule to check for them in the future.