New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Default implementation with derived Default in RNG capsule #1080

Merged
merged 1 commit into from Jul 6, 2018

Conversation

Projects
None yet
3 participants
@niklasad1
Copy link
Member

niklasad1 commented Jul 6, 2018

Pull Request Overview

This pull request removes the needless default implementation for App in the rng capsule!

Testing Strategy

This pull request was tested by compiles

TODO or Help Wanted

N/A

Documentation Updated

- [ ] Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

@alevy alevy changed the title rng-capsule `remove needless default implementation` Replace Default implementation with derived Default in RNG capsule Jul 6, 2018

@alevy

This comment has been minimized.

Copy link
Member

alevy commented Jul 6, 2018

Would be good to at least spot test with hardware.

@alevy alevy added the P-Upkeep label Jul 6, 2018

@bradjc

bradjc approved these changes Jul 6, 2018

Copy link
Contributor

bradjc left a comment

I tested on Hail with the RNG test app and the app worked as expected.

@niklasad1

This comment has been minimized.

Copy link
Member

niklasad1 commented Jul 6, 2018

Thanks @bradjc

@niklasad1 niklasad1 merged commit 48f4834 into master Jul 6, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@niklasad1 niklasad1 deleted the refactor/rng-capsule-remove-needless-default-impl branch Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment