New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: disallow warnings in CI builds #1085

Merged
merged 1 commit into from Jul 6, 2018

Conversation

Projects
None yet
2 participants
@ppannuto
Copy link
Member

ppannuto commented Jul 6, 2018

Pull Request Overview

We've never allowed warnings in-tree, but nothing in travis was actually enforcing this.

This causes builds with warnings to error only if the environment variable CI=true.

Testing Strategy

Compiling, injecting fake warnings, and lying about my environment.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

@ppannuto ppannuto added the P-Upkeep label Jul 6, 2018

@bradjc

bradjc approved these changes Jul 6, 2018

Copy link
Contributor

bradjc left a comment

Big fan of this.

What would be really sweet is if there was a way to run something like make travis that would do the checks that travis does, just locally.

@ppannuto ppannuto merged commit 6ffed19 into master Jul 6, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ppannuto ppannuto deleted the disallow-warnings branch Jul 6, 2018

@ppannuto ppannuto referenced this pull request Jul 6, 2018

Merged

Add rule for running CI tests locally #1086

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment