New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule for running CI tests locally #1086

Merged
merged 2 commits into from Jul 7, 2018

Conversation

Projects
None yet
2 participants
@ppannuto
Copy link
Member

ppannuto commented Jul 6, 2018

Pull Request Overview

As inspired by #1085, this adds a make ci target for running all continuous integration tests.

Testing Strategy

Compiling.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

ppannuto added some commits Jul 6, 2018

@ppannuto ppannuto added the P-Upkeep label Jul 6, 2018

@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Jul 6, 2018

Why do we no longer need the .travis-deploy-netlify script?

@ppannuto

This comment has been minimized.

Copy link
Member

ppannuto commented Jul 7, 2018

That hasn't been used in months. It should've been deleted forever ago.

(Could've been a separate PR, I just got lazy and lumped the CI fixes together)

@bradjc

bradjc approved these changes Jul 7, 2018

Copy link
Contributor

bradjc left a comment

Super cool.

@ppannuto ppannuto merged commit e5465c2 into master Jul 7, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ppannuto ppannuto deleted the local-ci branch Jul 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment