Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make most of `kernel` crate-visible only, rather than public. #1089
An enhancement to Rust is the
This PR updates the kernel crate to use this in many places where functions and variables shouldn't be accessible outside of the kernel crate.
This is part of tracking issue #1088.
This pull request was tested by compiling. It doesn't actually make any logic changes.
TODO or Help Wanted
@phil-levis I agree at a high level with the concern of hiding functionality that was previously public.
I think in the case of the kernel crate, since we haven't really thought carefully about a stable public interface, it's probably actually better to expose less publicly as early as possible (i.e. now) (really almost nothing should be public at the moment).
This is more urgently the the case for things in
@bradjc is it possible to summarize what is left public after this PR? My sense is that it should be very very very little, but hard to tell from the GitHub diff.
left a comment
I still find
I wonder if they plan do same for
I hope this syntax will never get stabilized