New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: use as_ptr() in appslice #1091

Merged
merged 1 commit into from Jul 6, 2018

Conversation

Projects
None yet
2 participants
@bradjc
Copy link
Contributor

bradjc commented Jul 6, 2018

We do not need to use as_ref() which requires unsafe.

Relevant documentation is here: https://doc.rust-lang.org/1.26.0/core/ptr/struct.Unique.html

Testing Strategy

This pull request was tested by running the adc test app on hail, and it seems to still work.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.
kernel: use as_ptr() in appslice
We do not need to use `as_ref()` which requires `unsafe`.
@ppannuto
Copy link
Member

ppannuto left a comment

Can we all take a moment to appreciate the ptr() function whose body is .ptr.ptr.as_ptr. This makes sense and all, but it's also ridiculous.

@ppannuto ppannuto added the P-Upkeep label Jul 6, 2018

@ppannuto ppannuto merged commit 06b3ef8 into master Jul 6, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ppannuto ppannuto deleted the appslice-ptr branch Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment