New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tock-regs: Add conditional 64bit support #1092

Merged
merged 3 commits into from Jul 8, 2018

Conversation

Projects
None yet
3 participants
@andre-richter
Copy link
Contributor

andre-richter commented Jul 7, 2018

Pull Request Overview

Implements #1087

Testing Strategy

Only locally built

TODO or Help Wanted

Maybe people to test on actual boards. I don't own any.

@ppannuto
Copy link
Member

ppannuto left a comment

Looks good to me, thanks!

I updated to drop the cfg building of the u64 impls. There's no harm in having them for our use cases (they're unreachable so they won't affect the built binary size).

@andre-richter

This comment has been minimized.

Copy link
Contributor

andre-richter commented Jul 7, 2018

I accidentally used a wrong email address in my commit. Please wait until I can push over it before merging.

Thanks !

@alevy

This comment has been minimized.

Copy link
Member

alevy commented Jul 7, 2018

Likewise @andre-richter, this looks good to me. Happy to merge whenever you've repushed with the "right" e-mail address :)

andre-richter and others added some commits Jul 7, 2018

tock-regs: don't guard u64 impls for IntLike
There's no harm in leaving these implemented for 32-bit MCUs, as they
won't be used so won't make the final binary. Following that, there's a
general preference for minimizing the build matrix.

@andre-richter andre-richter force-pushed the andre-richter:registers branch from 57e56fb to 1bd7f8a Jul 8, 2018

@andre-richter

This comment has been minimized.

Copy link
Contributor

andre-richter commented Jul 8, 2018

Okay, I'm set now 😅

@ppannuto ppannuto merged commit 8b64ec2 into tock:master Jul 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@ppannuto

This comment has been minimized.

Copy link
Member

ppannuto commented Jul 8, 2018

Closes #1087.

Thanks @andre-richter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment