New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad use of optioncell introduced by #1057 #1100

Merged
merged 1 commit into from Jul 9, 2018

Conversation

Projects
None yet
2 participants
@alevy
Copy link
Member

alevy commented Jul 8, 2018

Pull Request Overview

I merged #1057 when master had changed underneath it, so travis didn't
catch a misuse of the OptionCell type.

It's a simple fix, just need to replace instances of OptionCell#replace(callback) with OptionCell#insert(callback).

Testing Strategy

Compiles and builds now

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.
Fix bad use of optioncell introduced by #1057
I merged #1057 when master had changed underneath it, so travis didn't
catch a misuse of the OptionCell type. Simple fix.

@alevy alevy requested a review from ppannuto Jul 8, 2018

@alevy alevy added bug P-Upkeep labels Jul 8, 2018

@bradjc

bradjc approved these changes Jul 9, 2018

@bradjc bradjc merged commit f638195 into tock:master Jul 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment