capsules: add buzzer driver #1104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradjc
added
the
blocked
alevy
reviewed
Jul 9, 2018
capsules/src/buzzer_driver.rs
Outdated
|
|
||
| 1 => { | ||
| let frequency_hz = arg1 & 0xFFFF; | ||
| let duration_ms = cmp::min((arg1 >> 16) & 0xFFFF, 5000); |
There was a problem hiding this comment.
Might be nice to make 5000 a field of the capsule that the board decides on when initializing the capsule (maybe add a DEFAULT_MAX_BUZZ constant just so an indecisive board integrator can go with the value you chose).
bradjc
force-pushed
the
buzzer-pr
branch
3 times, most recently
from
8ba51d9
to
5e3a5d5
Compare
phil-levis
reviewed
Sep 26, 2018
There was a problem hiding this comment.
Overall, this looks good to me; I have a concern with #1003 but once that's resolved this should be good and I can mark approve.
bradjc
removed
the
blocked
bradjc
force-pushed
the
buzzer-pr
branch
2 times, most recently
from
2382b69
to
201f8ab
Compare
This is an interface for a simple buzzer. It supports time-shared access to the buzzer for multiple apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an interface for a simple buzzer. It supports time-shared access to the buzzer for multiple apps. Each "buzz" from an app can last up to 5 seconds.
Blocked on #1003 and #1103Testing Strategy
Tested on the ACD52832
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make formatall.