New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capsules: add buzzer driver #1104

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@bradjc
Copy link
Contributor

bradjc commented Jul 9, 2018

This is an interface for a simple buzzer. It supports time-shared access to the buzzer for multiple apps. Each "buzz" from an app can last up to 5 seconds.

Blocked on #1003 and #1103

Testing Strategy

Tested on the ACD52832

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

@bradjc bradjc added the blocked label Jul 9, 2018


1 => {
let frequency_hz = arg1 & 0xFFFF;
let duration_ms = cmp::min((arg1 >> 16) & 0xFFFF, 5000);

This comment has been minimized.

@alevy

alevy Jul 9, 2018

Member

Might be nice to make 5000 a field of the capsule that the board decides on when initializing the capsule (maybe add a DEFAULT_MAX_BUZZ constant just so an indecisive board integrator can go with the value you chose).

@bradjc bradjc force-pushed the buzzer-pr branch 3 times, most recently from 8ba51d9 to 5e3a5d5 Jul 11, 2018

@phil-levis
Copy link
Collaborator

phil-levis left a comment

Overall, this looks good to me; I have a concern with #1003 but once that's resolved this should be good and I can mark approve.

@bradjc bradjc force-pushed the buzzer-pr branch from c55baeb to a50cade Dec 6, 2018

@bradjc bradjc removed the blocked label Dec 6, 2018

@bradjc bradjc force-pushed the buzzer-pr branch 2 times, most recently from 2382b69 to 201f8ab Dec 6, 2018

@bradjc bradjc referenced this pull request Dec 11, 2018

Merged

capsules: add virtual_pwm #1103

2 of 2 tasks complete
capsules: add buzzer driver
This is an interface for a simple buzzer. It supports time-shared access
to the buzzer for multiple apps.

@bradjc bradjc force-pushed the buzzer-pr branch from 201f8ab to 39f8346 Dec 12, 2018

@bradjc bradjc closed this Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment