New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to tock-registers for publishing #1106

Merged
merged 3 commits into from Jul 14, 2018

Conversation

Projects
None yet
2 participants
@ppannuto
Copy link
Member

ppannuto commented Jul 10, 2018

Pull Request Overview

This is blocked on #1105.

This finishes the remaining bits for publishing, specifically fixing up doctests and adding metadata to the manifest.

Testing Strategy

Compiling.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.
@bradjc
Copy link
Contributor

bradjc left a comment

Same here.

I don't think that review applies to any of the changes for this PR? It's already blocked on #1105.

@ppannuto ppannuto force-pushed the publish-tock-registers branch from cd9340d to 114bd69 Jul 14, 2018

@ppannuto ppannuto removed the blocked label Jul 14, 2018

ppannuto added some commits Jul 9, 2018

tock-registers: fix doctests
The doc tests are not optimized for macros or top-level declration
examples, but here's the relevant bit for why this does what it does:
https://doc.rust-lang.org/beta/rustdoc/documentation-tests.html#documenting-macros

@ppannuto ppannuto force-pushed the publish-tock-registers branch from 114bd69 to 4359092 Jul 14, 2018

@ppannuto

This comment has been minimized.

Copy link
Member

ppannuto commented Jul 14, 2018

Rebased. This should be good to go now.

@bradjc

bradjc approved these changes Jul 14, 2018

@ppannuto ppannuto merged commit b4cd500 into master Jul 14, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ppannuto ppannuto deleted the publish-tock-registers branch Jul 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment