New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] UART + SPI HIL generic lifetimes #1107

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@ppannuto
Copy link
Member

ppannuto commented Jul 10, 2018

Pull Request Overview

Implements RFC #1074 for UART and SPI.

I started this a few days ago, but it became a bit of a 'give a mouse a cookie' situation. The goal was to make the UART HIL generic, but because the Sam4l USART mixes UART and SPI, this required making the SPI HIL support generic lifetimes as well. Then we're down a rabbit hole of co-dependencies, as making SPI support generic lifetimes required the Flash (which begat nonvolatile) and Radio (which begat crypto) HILs to update as well.

The current state is stuck on some lifetime issue in the networking stack that I haven't quite been able to resolve yet. However, I'm not going to be able to pick up this thread again for a few days at least, so I wanted to throw this out here in case anyone wanted to build on it.

Testing Strategy

(Failing to) compile.

TODO or Help Wanted

This pull request still needs to fixup some more lifetimes.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

ppannuto added some commits Jul 5, 2018

uart: remove `initialize` from the UART HIL
This implements RFC #1035 for the UART HIL. It splits the hardware-specific
initialization (power, clock assignment, pin assignment) from the uart-specific
configuration (baud rate, parity, stop bits, flow control), which is now
controlled by a new `configure` method for the UART HIL.
@phil-levis

This comment has been minimized.

Copy link
Collaborator

phil-levis commented Jul 10, 2018

Yeah, my sense is that this will cascade throughout the kernel.

@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Aug 17, 2018

Closed based on timeout.

@bradjc bradjc closed this Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment