New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capsules: add reset function to nrf serialization #1122

Merged
merged 1 commit into from Jul 18, 2018

Conversation

Projects
None yet
2 participants
@bradjc
Copy link
Contributor

bradjc commented Jul 18, 2018

Pull Request Overview

This pull request moves the reset operation of the nrf51822 serialization capsule into the capsule itself. That it was ever in the board file is probably an artifact of when that capsule was written more than anything else. It also exposes the reset function as a command in the syscall interface.

I believe this is necessary to make apps that use nrf serialization able to restart on faults.

Testing Strategy

This pull request was tested by verifying the hail app still sends packets.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required. (nrf_serialization doesn't have a doc in the syscalls folder)

Formatting

  • Ran make formatall.
@alevy

alevy approved these changes Jul 18, 2018

@alevy alevy added the P-Upkeep label Jul 18, 2018

@alevy

This comment has been minimized.

Copy link
Member

alevy commented Jul 18, 2018

bors r+

bors bot added a commit that referenced this pull request Jul 18, 2018

Merge #1122
1122: capsules: add reset function to nrf serialization r=alevy a=bradjc

### Pull Request Overview

This pull request moves the reset operation of the nrf51822 serialization capsule into the capsule itself. That it was ever in the board file is probably an artifact of when that capsule was written more than anything else. It also exposes the reset function as a command in the syscall interface.

I believe this is necessary to make apps that use nrf serialization able to restart on faults.


### Testing Strategy

This pull request was tested by verifying the hail app still sends packets.


### TODO or Help Wanted

n/a


### Documentation Updated

- [x] Updated the relevant files in `/docs`, or no updates are required. (nrf_serialization doesn't have a doc in the syscalls folder)

### Formatting

- [x] Ran `make formatall`.


Co-authored-by: Brad Campbell <bradjc5@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jul 18, 2018

@bors bors bot merged commit 25cb7ce into master Jul 18, 2018

4 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@bors bors bot deleted the nrf-reset branch Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment