New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf51: update clock to new register interface #1123

Merged
merged 1 commit into from Aug 2, 2018

Conversation

Projects
None yet
4 participants
@ppannuto
Copy link
Member

ppannuto commented Jul 18, 2018

Pull Request Overview

nrf51: Update clock to new regs interface

Testing Strategy

Compile-tested only.

TODO or Help Wanted

Someone with nrf51 HW make sure this doesn't break anything.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

@bradjc bradjc referenced this pull request Jul 18, 2018

Closed

Tracking: nRF5x to new register interface #809

17 of 17 tasks complete

@ppannuto ppannuto added the refactor label Jul 18, 2018

@alevy

alevy approved these changes Jul 18, 2018

@bradjc

bradjc approved these changes Jul 19, 2018

@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Jul 23, 2018

Is anyone likely to test this? The changes are pretty small, and look good.

@niklasad1

This comment has been minimized.

Copy link
Member

niklasad1 commented Jul 29, 2018

Sorry, I can't test it! Left my nrf51dk back in Berlin and I'm not back there in ~2 weeks!

@ppannuto

This comment has been minimized.

Copy link
Member

ppannuto commented Aug 2, 2018

bors r+

I think I'm inclined to call this safe and something we can back out if future testing reveals it to be necessary.

bors bot added a commit that referenced this pull request Aug 2, 2018

Merge #1123
1123: nrf51: update clock to new register interface r=ppannuto a=ppannuto

### Pull Request Overview

nrf51: Update clock to new regs interface

### Testing Strategy

Compile-tested only.

### TODO or Help Wanted

Someone with nrf51 HW make sure this doesn't break anything.

### Documentation Updated

- [x] Updated the relevant files in `/docs`, or no updates are required.

### Formatting

- [X] Ran `make formatall`.


Co-authored-by: Pat Pannuto <pat.pannuto@gmail.com>

@ppannuto ppannuto referenced this pull request Aug 2, 2018

Merged

nrf51: update radio to new register interface #1125

2 of 2 tasks complete
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Aug 2, 2018

@bors bors bot merged commit 1a8c5df into master Aug 2, 2018

4 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@bors bors bot deleted the nrf51-clock-regs branch Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment