New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launchxl Alarm Bug: Fix issue of board main.rs calling wrong rtc #1127

Merged
merged 1 commit into from Jul 19, 2018

Conversation

Projects
None yet
3 participants
@refugeesus
Copy link
Contributor

refugeesus commented Jul 19, 2018

Alarm will not call correctly otherwise

Pull Request Overview

This pull request fixes a bug where the kernel will seem to run correctly but no Alarm callback is called because launchxl main.rs implements Platform { ... alarm: ...} with the wrong rtc, breaking the AlarmDriver.

Testing Strategy

Tested by running blink application which uses alarm for toggling the LED's

Formatting

  • Ran make formatall.
launchxl: Changed all cc26xx::rtc instances to cc26x2::rtc for alarm …
…driver. Alarm will not call correctly otherwise
@bradjc

bradjc approved these changes Jul 19, 2018

@alevy

alevy approved these changes Jul 19, 2018

Copy link
Member

alevy left a comment

bors r+

bors bot added a commit that referenced this pull request Jul 19, 2018

Merge #1127
1127: Launchxl Alarm Bug: Fix issue of board main.rs calling wrong rtc r=alevy a=refugeesus

Alarm will not call correctly otherwise

### Pull Request Overview

This pull request fixes a bug where the kernel will seem to run correctly but no Alarm callback is called because launchxl main.rs implements Platform { ... alarm: ...} with the wrong rtc, breaking the AlarmDriver. 

### Testing Strategy

Tested by running blink application which uses alarm for toggling the LED's

### Formatting

- [ ] Ran `make formatall`.


Co-authored-by: Robert Keith <robertfkeith@me.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jul 19, 2018

@bors bors bot merged commit e4d08fa into tock:master Jul 19, 2018

3 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment