Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: Initialize the process app_idx #1196

Merged
merged 1 commit into from Oct 23, 2018

Conversation

@bradjc
Copy link
Contributor

commented Oct 23, 2018

Pull Request Overview

This pull request fixes process.rs to initialize the app_idx for the process. Not doing this causes some weird errors.

It's likely that this was in #1144 at some point, but got accidentally dropped during a rebase as other PRs were merged.

Testing Strategy

This pull request was tested by running multiple apps on Hail.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.
@alevy
alevy approved these changes Oct 23, 2018
Copy link
Member

left a comment

Strong approve!

@alevy

This comment has been minimized.

Copy link
Member

commented Oct 23, 2018

bors r+

bors bot added a commit that referenced this pull request Oct 23, 2018
Merge #1196
1196: kernel: Initialize the process app_idx r=alevy a=bradjc

### Pull Request Overview

This pull request fixes process.rs to initialize the app_idx for the process. Not doing this causes some weird errors.

It's likely that this was in #1144 at some point, but got accidentally dropped during a rebase as other PRs were merged.


### Testing Strategy

This pull request was tested by running multiple apps on Hail.


### TODO or Help Wanted

n/a


### Documentation Updated

- [x] Updated the relevant files in `/docs`, or no updates are required.

### Formatting

- [x] Ran `make formatall`.


Co-authored-by: Brad Campbell <bradjc5@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2018

@bors bors bot merged commit 5ce66eb into master Oct 23, 2018

4 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@bors bors bot deleted the set-app-index branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.