Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted thumb check #1315

Merged
merged 1 commit into from May 15, 2019

Conversation

@sv2bb
Copy link
Contributor

commented May 14, 2019

Pull Request Overview

This pull request deletes the thumb check in the kernel to keep it platform agnostic. I'm working on getting Tock running on risc-v and this check caused a problem when trying to run an application.

Testing Strategy

I ran it on the Hail board using the blink app and everything seems to be in working order. Also allows load processes to complete on the Arty-e21 (risc-v board).

TODO or Help Wanted

Not sure if this check needs to be put somewhere else in the platform specific code.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

@sv2bb sv2bb changed the title deleted thumb check Deleted thumb check May 14, 2019

@brghena
Copy link
Contributor

left a comment

This was only really ever there as a sanity check. The compile process in libtock-c for ARM Cortex-Ms already ensures that code is compiled into thumb mode. I'd say we're probably good just removing this altogether rather than trying to add chip-specific process checks.

@alevy alevy merged commit 8349d06 into tock:master May 15, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.