New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: semantic instead of lexical version compare #724

Merged
merged 1 commit into from Jan 13, 2018

Conversation

Projects
None yet
2 participants
@ppannuto
Member

ppannuto commented Jan 13, 2018

Pull Request Overview

Addresses the problem raised in #717.

This is a bit obnoxious to do in a cross-platform way, but this pure-bash
solution should work according to the wonderful wonderful Internet.

Testing Strategy

Running the script with faked versions to make sure it did the right thing.

TODO or Help Wanted

Documentation Updated

  • Kernel: The relevant files in /docs have been updated or no updates are required.
  • Userland: The application README has been added, updated, or no updates are required.

Formatting

  • make formatall has been run.
tools: semantic instead of lexical version compare
This is a bit obnoxious to do in a cross-platform way, but this pure-bash
solution should work according to the wonderful wonderful Internet.
@brghena

Fixes things for me

@brghena brghena merged commit 09ed0a5 into master Jan 13, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ppannuto ppannuto deleted the semver-in-bash branch Jan 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment