Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Symmetric Encryption HIL] Don't use block_size in the key context #749
Pull Request Overview
Changes usage of constants in the AES128 interface because we assume the block size and key size are the same. Well. yes they are both 16 bytes in AES128 but that is not the case for AES192 and AES256 so I wanted to clarify that!
Run the AES_CTR Tests on nRF52-DK
TODO or Help Wanted
This seems fine to me. When we have support for const generics, these will probably move to a trait specified constant, which makes even more sense, right?
I think @daniel-scs should at least sign off on this, but my position is that if he's cool with it, we should merge.