New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved AES module over to new Register interface. #751

Merged
merged 3 commits into from Feb 28, 2018

Conversation

Projects
None yet
4 participants
@phil-levis
Collaborator

phil-levis commented Feb 19, 2018

Pull Request Overview

This pull request updates the AES module to use the new Register macros.

Testing Strategy

This pull request was tested by running the AES tests in boards/imix/src: aes_ccm_test and aes_test.

TODO or Help Wanted

Should be good to go.

Documentation Updated

  • Kernel: The relevant files in /docs have been updated or no updates are required.
  • Userland: The application README has been added, updated, or no updates are required.

Formatting

  • [x ] make formatall has been run.
@niklasad1

This comment has been minimized.

Show comment
Hide comment
@niklasad1

niklasad1 Feb 19, 2018

Member

@phil-levis would be good if you can run the AES tests for imix, you find them in boards/imix/src/aes

Member

niklasad1 commented Feb 19, 2018

@phil-levis would be good if you can run the AES tests for imix, you find them in boards/imix/src/aes

@phil-levis

This comment has been minimized.

Show comment
Hide comment
@phil-levis

phil-levis Feb 19, 2018

Collaborator

I ran aes_ccm_test and aes_test and both passed; are there others?

Collaborator

phil-levis commented Feb 19, 2018

I ran aes_ccm_test and aes_test and both passed; are there others?

@niklasad1

This comment has been minimized.

Show comment
Hide comment
@niklasad1

niklasad1 Feb 19, 2018

Member

Good, no that’s all because userspace functionlity is removed for now

Member

niklasad1 commented Feb 19, 2018

Good, no that’s all because userspace functionlity is removed for now

@daniel-scs daniel-scs referenced this pull request Feb 20, 2018

Merged

Support for EK-TM4C1294XL #750

1 of 8 tasks complete
@alevy

alevy approved these changes Feb 27, 2018

@ppannuto

Looks good to me, @phil-levis merge whenever you're ready 👍

@phil-levis phil-levis merged commit 6e2b6c3 into master Feb 28, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@bradjc bradjc deleted the sam4l-aes-new-reg-interface branch Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment