New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: flush the buffer if needed before panic'ing #762

Merged
merged 1 commit into from Mar 2, 2018

Conversation

Projects
None yet
3 participants
@ppannuto
Member

ppannuto commented Feb 28, 2018

Pull Request Overview

If there are entries in the debug buffer that haven't started printing
when a panic occurs, they'll be dropped. This remedies that.

In the short term, just implemented for hail. With a forthcoming panic
consolidation, it'll propagate to all boards.

Formatting

  • make formatall has been run.
Show outdated Hide outdated kernel/src/debug.rs Outdated
@ppannuto

This comment has been minimized.

Show comment
Hide comment
@ppannuto

ppannuto Mar 2, 2018

Member

Branden pointed out that the problem I brought up is quite literally what Traits are for (hello, Pat.. ay yi yi). Updated to put flush in the debug module and have all boards call it.

Member

ppannuto commented Mar 2, 2018

Branden pointed out that the problem I brought up is quite literally what Traits are for (hello, Pat.. ay yi yi). Updated to put flush in the debug module and have all boards call it.

@brghena

brghena approved these changes Mar 2, 2018

debug: flush the buffer if needed before panic'ing
If there are entries in the debug buffer that haven't started printing
when a panic occurs, they'll be dropped. This remedies that.

@ppannuto ppannuto merged commit 0ff5913 into master Mar 2, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ppannuto ppannuto deleted the debug-flush branch Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment