New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common_regs] #[repr(packed)] is unsafe since a while go #772

Merged
merged 1 commit into from Mar 5, 2018

Conversation

Projects
None yet
3 participants
@niklasad1
Member

niklasad1 commented Mar 4, 2018

#[repr(C, packed)] -> #[repr[C]

Packed is unsafe since a while go
#[repr(C, packed)] -> #[repr[C]

@ppannuto ppannuto merged commit 8ec4146 into master Mar 5, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ppannuto ppannuto deleted the niklasad1-registers branch Mar 5, 2018

@brghena

This comment has been minimized.

Show comment
Hide comment
@brghena

brghena Mar 5, 2018

Contributor

Hey, was this tested at all? Maybe I'm being to worried about nothing, but I'm always concerned that removing packed might screw something up.

Contributor

brghena commented Mar 5, 2018

Hey, was this tested at all? Maybe I'm being to worried about nothing, but I'm always concerned that removing packed might screw something up.

@ppannuto

This comment has been minimized.

Show comment
Hide comment
@ppannuto

ppannuto Mar 5, 2018

Member

This only changed the README to match the code. The packed removal changed ~a month ago with the last rust version bump

Member

ppannuto commented Mar 5, 2018

This only changed the README to match the code. The packed removal changed ~a month ago with the last rust version bump

@brghena

This comment has been minimized.

Show comment
Hide comment
@brghena

brghena Mar 5, 2018

Contributor

Ooh, I didn't see that this was in a README

Contributor

brghena commented Mar 5, 2018

Ooh, I didn't see that this was in a README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment