New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cortex-M* to StaticRef (some done by removing duplicate code) #996

Merged
merged 5 commits into from Jun 19, 2018

Conversation

Projects
None yet
3 participants
@bradjc
Copy link
Contributor

bradjc commented Jun 13, 2018

Pull Request Overview

This pull request updates Cortex-M4 to use StaticRef.

Testing Strategy

todo

TODO or Help Wanted

n/a

Documentation Updated

  • Kernel: Updated the relevant files in /docs, or no updates are required.
  • Userland: Added/updated the application README, if needed.

Formatting

  • Ran make formatall.

bradjc added some commits Jun 13, 2018

arch: remove copies of generic cortex-m code
Things in the arch folder had been copied several times, this moves the
copied code to the cortex-m crate and lets the specific arch crates
re-export what they want.

@bradjc bradjc referenced this pull request Jun 14, 2018

Closed

Tracking: Use StaticRef #988

8 of 8 tasks complete

@bradjc bradjc changed the title Cortex-M4 to StaticRef Cortex-M* to StaticRef Jun 14, 2018

@alevy

This comment has been minimized.

Copy link
Member

alevy commented Jun 16, 2018

There's more going on here than the title suggests :) Since Travis is complaining anyway, maybe a more descriptive title and description is in order before merging?

@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Jun 17, 2018

There's more going on here than the title suggests

Well not really, this is a way to get the entire arch crate to use staticref.

And this doesn't seem like the fault of this branch:

image

@bradjc bradjc changed the title Cortex-M* to StaticRef Cortex-M* to StaticRef (some done by removing duplicate code) Jun 17, 2018

@alevy

alevy approved these changes Jun 19, 2018

@brghena
Copy link
Contributor

brghena left a comment

This is great, because it answers the deeper question of how to handle the cortex-m3 crate moving forward. Until its used on a board in mainline tock, it can just exist as a lib file pointing to generic cortex-m support files.

@alevy alevy merged commit 2bcfc69 into master Jun 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@alevy alevy deleted the arch-staticref branch Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment