New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: updating settlement admins is broken #396

Closed
toconnell opened this Issue Nov 5, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@toconnell
Owner

toconnell commented Nov 5, 2017

From email:

[57e9fd378740d91da9300003] has submitted an error report!

The report goes as follows:
I'm unable to assign someone in my group admin permission. It flashes "error".

Also, while trying to replicate this, I learned two things:

  1. the controls for this use the legacy webapp (which is bad)
  2. the legacy webapp call is actually one-way: it cannot be unset.

So, tl;dr, the patch/fix for this is to port the settlement admin stuff to AngularJS/API:

  • fix the controls so that users can have their admin status removed
  • API: create a new route
  • API: create a new method to update settlement admins

@toconnell toconnell self-assigned this Nov 5, 2017

@toconnell toconnell referenced this issue Nov 5, 2017

Closed

Deprecate kdmManager.js modifyAsset() method #215

16 of 16 tasks complete
@toconnell

This comment has been minimized.

Show comment
Hide comment
@toconnell

toconnell Nov 5, 2017

Owner

Done. I'm rolling this out in the next one.

Owner

toconnell commented Nov 5, 2017

Done. I'm rolling this out in the next one.

@toconnell toconnell closed this Nov 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment