New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline Re-do #476

Closed
toconnell opened this Issue Feb 4, 2018 · 3 comments

Comments

Projects
None yet
1 participant
@toconnell
Copy link
Owner

toconnell commented Feb 4, 2018

The Timeline controls are really bad! Let's fix them!

At a minimum, we have to:

  • improve responsiveness (it's a resource pig on the JS side)
  • fix the issue where ending a year makes weird shit happen. Maybe with some clever CSS animations that show the change from one LY to the next (e.g. spin the current LY like a slot machine)?

Ultimately, the solution is going to be to create a new UI/UX concept where there is a dedicated editing "pane" or modal, where the user can

  1. click to "edit" an LY
  2. add/remove events from that LY
  3. click to save and then
  4. on click to save, sees an animation that closes out the window and makes their change, e.g. by "flashing" a color border or something around the edited year.

Design:

timeline_redo

Technically, here's how I think that breaks down into tasks

  • webapp needs to look up events from the settlement events, rather than depending on having that info from the API, which should no longer send it
  • API should tell us how many events are in a year
  • redo the controls so that they're one column at mobile width and two columns at tablet/wide (no one's going past LY 35: we need to stop acting as if they might)
  • create the "edit" modal or pane
  • OPTIONAL create a new route for setting/updating a whole LY, instead of atomic events
  • document the new routes
  • deprecate the old routes for timeline editing
  • dynamic columns at tablet and wide resolution
  • API needs the ability to add LYs to the timeline (maybe steal the "add five years" idea from that knucklehead with the spreadsheets)
@toconnell

This comment has been minimized.

Copy link
Owner

toconnell commented Feb 14, 2018

The facelift is really coming along and it's almost done:

timeline_refactor_wip

@toconnell

This comment has been minimized.

Copy link
Owner

toconnell commented Feb 15, 2018

@toconnell

This comment has been minimized.

Copy link
Owner

toconnell commented Mar 6, 2018

Alright, this is ready to ship. Cleaning up a few rough edges, and then it's going out.

@toconnell toconnell closed this Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment